Quant Firms Champion 'One PR Per Day' Rule
An engineering practice from quant firms like Jane Street, known as the "One PR per day" rule, is being highlighted as a method to improve continuous delivery and code discipline. The approach encourages developers to ship small, incremental, and easily reviewable changes daily. This practice inherently aligns with improving high-performing DORA metrics such as deployment frequency and lead time for changes.
- The practice of small, daily pull requests is a direct reflection of a broader engineering philosophy that values continuous integration. High-performing organizations that practice continuous integration are shown to have better business outcomes, including profitability and market share, as well as lower levels of employee burnout. - At Jane Street, the emphasis is on a rigorous and scalable code review process for all changes to production-critical code. They developed an in-house tool called Iron, which is a hybrid version control and review system that focuses on reviewing the entire state of a branch rather than individual commits. This ensures that even small, incremental changes are reviewed in their full context before being merged. - From a business perspective, the ROI of improving DORA metrics through practices like small, daily PRs can be framed in terms of "effective developer hours." By reducing the time developers waste on post-pull request administrative tasks, their capacity to support revenue-generating activities increases, directly impacting the bottom line. For example, a 10% reduction in wasted time for a 20-developer team supporting $20M in ARR could be valued at an additional $2M in ARR. - The principle of small pull requests directly combats "code review fatigue." When faced with large, complex changes, reviewers are more likely to skim the code and provide a superficial "LGTM" (Looks Good To Me). Smaller, more focused reviews lead to more thorough feedback and higher code quality. - In the high-stakes environment of fintech, continuous delivery, supported by practices like daily PRs, is crucial for balancing innovation with security and regulatory compliance. Automated testing and deployment pipelines, which are hallmarks of continuous delivery, ensure that every change is traceable and auditable. - The evolution of the quant developer role now requires a deeper understanding of market dynamics and trading strategies, not just low-latency coding. This shift means that the code they produce has a direct and measurable financial impact, making the reliability and speed afforded by practices like small, frequent releases even more critical. - The rise of AI is set to transform the "One PR Per Day" workflow. AI-powered tools can now automate the generation of pull request descriptions and summaries from code changes, saving developers time and ensuring consistency. Furthermore, AI code review tools can provide instant feedback on pull requests, detecting potential bugs, security vulnerabilities, and style inconsistencies in real-time. - While the "One PR Per Day" rule is a useful guideline, it's important to avoid a rigid focus on the number of pull requests as a primary performance metric. At senior levels, the emphasis shifts from the quantity of code output to the delivery of high-leverage code that solves complex problems or is highly educational for the team.
